test: fix flaky test-http2-close-while-writing #61764
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use stream.once() instead of stream.on() for the 'data' event handler to prevent multiple calls when receiving large data chunks. The test sends 64KB of data which may arrive in multiple chunks, causing the destroy callback to fire multiple times and leading to intermittent timeouts on macOS. Refs: nodejs/reliability#1459
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61764 +/- ##
==========================================
- Coverage 89.74% 89.74% -0.01%
==========================================
Files 675 675
Lines 204642 204642
Branches 39322 39320 -2
==========================================
- Hits 183657 183647 -10
- Misses 13257 13283 +26
+ Partials 7728 7712 -16 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky test
test/parallel/test-http2-close-while-writing.jswhich was timing out on macOS.Problem
The test uses
stream.on('data', ...)which can fire multiple times when receiving the 64KB data chunk sent by the client. Eachdataevent triggersclient_stream.destroy()viaprocess.nextTick(), leading to multiple destroy calls and intermittent timeouts.Solution
Changed
stream.on('data', ...)tostream.once('data', ...)to ensure the callback only fires once, regardless of how many data chunks arrive. This pattern is consistent with similar tests liketest-http2-many-writes-and-destroy.js.Verification
Verified with
python3 tools/test.py --repeat 100without failures.Refs: nodejs/reliability#1459